[Python-Dev] hg.python.org Mercurial upgrade

[Ezio Melotti]

On Thu, Jan 24, 2013 at 4:29 AM, Chris Jerdonek
<chris.jerdonek at gmail.com> wrote:
> On Wed, Jan 23, 2013 at 6:16 PM, Ezio Melotti <ezio.melotti at gmail.com> wrote:
>> On Wed, Jan 23, 2013 at 9:43 PM, Antoine Pitrou <solipsis at pitrou.net> wrote:
>>> On Wed, 23 Jan 2013 20:41:11 +0100
>>> "Amaury Forgeot d'Arc" <amauryfa at gmail.com> wrote:
>>>> 2013/1/22 Antoine Pitrou <solipsis at pitrou.net>
>>>>
>>>> > I've upgraded the Mercurial version on hg.python.org. If there any
>>>> > problems, don't hesitate to post here.
>>>> >
>>>>
>>>> I've noticed a display glitch with the hg viewer:
>>>> http://hg.python.org/cpython/rev/6df0b4ed8617#l2.8
>>>> There is a "[#14591]" link which causes the rest of the line to be shifted.
>>>
>>> Indeed. This is not because of the upgrade, but because of a new regexp
>>> Ezio asked me to insert in the Web UI configuration :-)
>>>
>>
>> FWIW this was an attempt to fix the links to issues in
>> http://hg.python.org/cpython/.
>> AFAIU the interhg extension used here to turn "#12345" to links
>> affects at least 3 places:
>>   1) the description of each changeset in the "shortlog" page (e.g.
>> http://hg.python.org/cpython/);
>>   2) the description at the top of the "rev" page (e.g.
>> http://hg.python.org/cpython/rev/6df0b4ed8617);
>>   3) the code in the "diff"/"rev"/"annotate" and possibly other pages
>> (e.g. http://hg.python.org/cpython/rev/6df0b4ed8617#l2.6);
>> With the previous solution, case 1 was broken, but links for cases 2-3
>> worked fine. The problem is that in 1 the description is already a
>> link, so the result ended up being something like '<a
>> href="rev/...">Issue <a href="b.p.o/12345">#12345</a> is now
>> fixed</a>'.
>> With the new solution 1-2 work (the links are added/moved at the end),
>> but it's glitched for case 3.
>> Unless interhg provides a way to limit the replacement only to
>> specific places and/or use different replacements for different
>> places, we will either have to live with these glitches or come up
>> with a proper fix done at the right level.
>
> How does the above relate to this issue?
>
> http://bugs.python.org/issue15919
>

This is exactly the problem I fixed.  I added a few more comments on
the issue and closed it.

Best Regards,
Ezio Melotti


> --Chris