[Python-Dev] PEP 435: pickling enums created with the functional API

[Guido van Rossum]

On Thu, May 9, 2013 at 7:17 AM, Nick Coghlan <ncoghlan at gmail.com> wrote:

> As Eric noted on the tracker issue, a keyword only "module" argument may
> be a better choice for both than allowing dotted names. A separate
> parameter is easier to use with __name__ to avoid hardcoding the module
> name.


+1. This is a good one. While adding module=__name__ is actually more
typing than passing __name__ + '.Color' as the class name, the current
proposal (parsing for dots) makes it very attractive to do the wrong thing
and hardcode the module name. Then typing the module incorrectly is very
easy, and the mistake is easily overlooked because it won't be noticed
until you actually try to pickle a member.

At the very least, the PEP should provide a rationale for the current
> choice.
>
> Cheers,
> Nick.
>
> >
> > Eli
> >
> >
>
> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> http://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe:
> http://mail.python.org/mailman/options/python-dev/guido%40python.org
>
>


-- 
--Guido van Rossum (python.org/~guido)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-dev/attachments/20130509/11a9ad1a/attachment.html>