[Python-Dev] [Python-checkins] cpython: Provide a more readable representation of socket on repr().

[Nick Coghlan]

On 13 November 2013 08:52, Victor Stinner <victor.stinner at gmail.com> wrote:
> Hi Giampaolo,
>
> You forgot to update tests after your change in repr(socket). Tests
> are failing on buildbots, just one example:
>
> ======================================================================
> FAIL: test_repr (test.test_socket.GeneralModuleTests)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/var/lib/buildslave/3.x.murray-gentoo/build/Lib/test/test_socket.py",
> line 653, in test_repr
>     self.assertIn('family=%i' % socket.AF_INET, repr(s))
> AssertionError: 'family=2' not found in "<socket.socket fd=22,
> family=AddressFamily.AF_INET, type=SocketType.SOCK_STREAM, proto=0,
> laddr=('0.0.0.0', 0)>"

I fixed this to turn the buildbots green again before committing the
codec error handling changes.

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia