[Python-Dev] cpython: Rename contextlib.ignored() to contextlib.ignore().

Ethan Furman ethan at stoneleaf.us
Sat Oct 12 22:41:40 CEST 2013


On 10/11/2013 09:05 PM, Ethan Furman wrote:
> On 10/11/2013 07:47 PM, Stephen J. Turnbull wrote:
>> Nick Coghlan writes:
>>
>>   > (RDM is also right that the exception still has the effect of
>>   > terminating the block early, but I view names as mnemonics rather
>>   > than necessarily 100% accurate descriptions of things).
>
> While I agree that mnemonics are helpful in the right circumstances, these aren't them, not for this name.  We aren't
> /just/ ignoring the exception, the exception is having a very real effect -- it's terminating the with block.

In case it wasn't clear (and it wasn't to me on rereading it ;) this comment was towards Nick, not Stephen.  break_on 
reads just fine to me, although leave_on is probably better.

--
~Ethan~


More information about the Python-Dev mailing list