[Python-Dev] Regarding stdlib socket module, _fileobject.flush() method using ._rbufsize instead of ._wbufsize

[Guido van Rossum]

So that's hex rev dca3cb19dbdd.

I'm confident that it is a copy/paste bug. It doesn't have any effect
AFAICT though, since given the analysis the OP posted, max(self._wbufsize,
self.bufsize) and max(self._rbufsize, self.bufsize) always come out to the
same. Additionally, the bug is no longer present in Python 3.


On Thu, Oct 17, 2013 at 3:23 AM, Antoine Pitrou <solipsis at pitrou.net> wrote:

> On Wed, 16 Oct 2013 21:30:52 -0400
> Terry Reedy <tjreedy at udel.edu> wrote:
>
> > On 10/16/2013 5:01 PM, Peter Portante wrote:
> > > Hello,
> > >
> > > Is there a reason why the stdlib socket module _fileobject.flush()
> > > method is using ._rbufsize instead of ._wbufsize at line 297 (Python
> > > 2.7.3), where it determines the buffer_size value to be used for
> > > _sock.sendall()?  Does anybody know the history behind this?
> >
> > Annotations and history show that line is from
> > 61875, 2010-5-23, J P Calderone, Merged revisions 74426...
> > I do not understand the message.
>
> When mentioning Mercurial changesets, please post the
> (hexadecimal) changeset id, not the revision number, since revision
> numbers are not stable accross clones.
> http://mercurial.selenic.com/wiki/RevisionNumber
>
> Regards
>
> Antoine.
>
>
> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> https://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe:
> https://mail.python.org/mailman/options/python-dev/guido%40python.org
>



-- 
--Guido van Rossum (python.org/~guido)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-dev/attachments/20131017/abeef360/attachment.html>