[Python-Dev] On suppress()'s trail blazing (was Re: cpython: Rename contextlib.ignored() to contextlib.ignore())

Xavier Morel catch-all at masklinn.net
Thu Oct 17 22:57:22 CEST 2013


On 2013-10-17, at 22:11 , Ethan Furman wrote:

> On 10/17/2013 01:03 PM, Terry Reedy wrote:
>> 
>> class suppress:
>>   def __init__(self, *exceptions):
>>     self.exceptions = exceptions
>>   def __exit__(self, etype, eval, etrace):
>>     return etype in self.exceptions
> 
> This fails when etype is a subclass of the exceptions, as mentioned in the original issue.

That's fixed by using `issubclass` and does not infirm Terry's point does it?


More information about the Python-Dev mailing list