[Python-Dev] [Python-checkins] cpython: Issue #19330: Handle the no-docstrings case in tests

[Serhiy Storchaka]

26.10.13 15:50, Stefan Krah написав(ла):
> nick.coghlan <python-checkins at python.org> wrote:
>> http://hg.python.org/cpython/rev/a9bbc2d0c1dc
>> -HAVE_DOCSTRINGS = (check_impl_detail(cpython=False) or
>> -                   sys.platform == 'win32' or
>> -                   sysconfig.get_config_var('WITH_DOC_STRINGS'))
>> +# Rather than trying to enumerate all the cases where docstrings may be
>> +# disabled, we just check for that directly
>> +
>> +def _check_docstrings():
>> +    """Just used to check if docstrings are enabled"""
>> +
>> +HAVE_DOCSTRINGS = (_check_docstrings.__doc__ is not None)
>>
>>   requires_docstrings = unittest.skipUnless(HAVE_DOCSTRINGS,
>
> I think that does not detect --without-doc-strings (i.e. the C docstrings are
> empty).

Indeed. HAVE_DOCSTRINGS was introduced to skip tests for the C 
docstrings. Python docstrings tests are skipped if sys.flags.optimize >= 2.