[Python-Dev] cpython: Issue #18408: Add a new PyFrame_FastToLocalsWithError() function to handle

Victor Stinner victor.stinner at gmail.com
Tue Oct 29 10:38:23 CET 2013


2013/10/29 Georg Brandl <g.brandl at gmx.net>:
> Am 29.10.2013 01:19, schrieb victor.stinner:
>> http://hg.python.org/cpython/rev/4ef4578db38a
>> changeset:   86715:4ef4578db38a
>> user:        Victor Stinner <victor.stinner at gmail.com>
>> date:        Tue Oct 29 01:19:37 2013 +0100
>> summary:
>>   Issue #18408: Add a new PyFrame_FastToLocalsWithError() function to handle
>> exceptions when merging fast locals into f_locals of a frame.
>> PyEval_GetLocals() now raises an exception and return NULL on failure.
>
> You'll have to either make this private or document it.
>
> Georg

I didn't find the documentation of PyFrame_FastToLocals(). Please open
an issue if you consider that these functions must be documented.

IMO these functions should be private because very low-level, but it's
too late: PyFrame_FastToLocals() is part of the stable ABI, even if
it's not documented.

PyFrame_FastToLocalsWithError() is the same than
PyFrame_FastToLocals(), except that it has a return value and keep the
exception.

Victor


More information about the Python-Dev mailing list