[Python-Dev] asdl.py and Python-ast.[hc]

[Eli Bendersky]

On Thu, Sep 26, 2013 at 7:18 AM, Brett Cannon <brett at python.org> wrote:

>
>
>
> On Thu, Sep 26, 2013 at 9:52 AM, Eli Bendersky <eliben at gmail.com> wrote:
>
>> Hi All,
>>
>> Earlier this morning I had a slight tackle with a couple of the 3.4 bots
>> (sorry everyone!). I fixed some problems in asdl.py -
>> http://hg.python.org/cpython/rev/21d46e3ae60c - and used the 'with'
>> statement. Some bots don't have Python 2.6+ and couldn't bootstrap
>> Python-ast.h/c
>>
>> Two questions:
>>
>> * Should I always check-in Python-ast.h and Python-ast.c when I touch
>> asdl* ? The generated files are unchanged, it's only the timestamp that
>> changed.
>>
>
> If Python-ast.* are checked in then yes.
>

Hmm, how do I do that? hg doesn't accept them for commit since their
contents are not changed.


>
>
>> * Can we, in theory, use new Pythons for asdl* code, because Python-ast.*
>> are, in fact, checked in so they don't have to be rebuilt by the bots or
>> users?
>>
>
> I don't see why not. the touch extension for hg is there specifically for
> these files to prevent having to regenerate them.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-dev/attachments/20130926/2d229fc4/attachment.html>