[Python-Dev] [Python-checkins] cpython: fix #21076: turn signal module constants into enums

Brett Cannon bcannon at gmail.com
Fri Apr 4 16:43:56 CEST 2014


On Fri Apr 04 2014 at 10:34:06 AM, Victor Stinner <victor.stinner at gmail.com>
wrote:

> 2014-04-04 16:21 GMT+02:00 Brett Cannon <brett at python.org>:
> > Fix is in rev c6e63bb132fb.
>
> Hum, this one was not enough for me. I also modified Modules/
> Setup.config.in:
>

Wasn't for me either in the end as it failed when I did a distclean. The
unfortunately bit me in the middle of trying to get a 3.4->default merge so
I just tried to do the best I could. This might take a little while to
clean up as the Windows 7 buildbot now builds -- which it has been doing
for a while -- but claims it can't find _signal.sigpending which I can at
least see on OS X so that bit of code my need tweaking.

-Brett


>
> changeset:   90137:df5120efb86e
> tag:         tip
> user:        Victor Stinner <victor.stinner at gmail.com>
> date:        Fri Apr 04 16:30:04 2014 +0200
> files:       Modules/Setup.config.in
> description:
> Issue #21076: the C signal module has been renamed to _signal
>
>
> diff -r c6e63bb132fb -r df5120efb86e Modules/Setup.config.in
> --- a/Modules/Setup.config.in   Fri Apr 04 10:20:28 2014 -0400
> +++ b/Modules/Setup.config.in   Fri Apr 04 16:30:04 2014 +0200
> @@ -7,7 +7,7 @@
>  @USE_THREAD_MODULE at _thread _threadmodule.c
>
>  # The signal module
> - at USE_SIGNAL_MODULE@signal signalmodule.c
> + at USE_SIGNAL_MODULE@_signal signalmodule.c
>
>  # The rest of the modules previously listed in this file are built
>  # by the setup.py script in Python 2.1 and later.
>
> Victor
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-dev/attachments/20140404/cbdcc865/attachment.html>


More information about the Python-Dev mailing list