[Python-Dev] cpython (2.7): do not generate pipe names in the temporary dir

[Antoine Pitrou]

On Wed, 16 Apr 2014 08:40:33 -0700
Benjamin Peterson <benjamin at python.org> wrote:

> On Wed, Apr 16, 2014, at 7:39, Antoine Pitrou wrote:
> > On Mon, 14 Apr 2014 18:24:44 +0200 (CEST)
> > benjamin.peterson <python-checkins at python.org> wrote:
> > > http://hg.python.org/cpython/rev/ea677e26dbeb
> > > changeset:   90269:ea677e26dbeb
> > > branch:      2.7
> > > parent:      90261:c095ff9b0e84
> > > user:        Benjamin Peterson <benjamin at python.org>
> > > date:        Mon Apr 14 12:24:37 2014 -0400
> > > summary:
> > >   do not generate pipe names in the temporary dir
> > > 
> > > files:
> > >   Lib/multiprocessing/connection.py |  2 +-
> > >   1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > 
> > > diff --git a/Lib/multiprocessing/connection.py b/Lib/multiprocessing/connection.py
> > > --- a/Lib/multiprocessing/connection.py
> > > +++ b/Lib/multiprocessing/connection.py
> > > @@ -90,7 +90,7 @@
> > >          return tempfile.mktemp(prefix='listener-', dir=get_temp_dir())
> > >      elif family == 'AF_PIPE':
> > >          return tempfile.mktemp(prefix=r'\\.\pipe\pyc-%d-%d-' %
> > > -                               (os.getpid(), _mmap_counter.next()))
> > > +                               (os.getpid(), _mmap_counter.next()), dir="")
> > 
> > This is some Windows-specific code, right? Did you witness problems
> > with this? Your commit message doesn't mention an issue number.
> 
> http://buildbot.python.org/all/builders/x86%20Windows7%202.7/builds/2549/steps/test/logs/stdio
> 
> I'd be interested to know how that ever worked.

I don't know, but perhaps opening an issue would allow a Windows expert
(or Richard) to chime in.

Regards

Antoine.