[Python-Dev] [Python-checkins] cpython: Close #20656: Fix select.select() on OpenBSD 64-bit

[Victor Stinner]

Hi,

2014-02-18 6:19 GMT+01:00 Zachary Ware <zachary.ware at gmail.com>:
> On Mon, Feb 17, 2014 at 6:36 PM, victor.stinner
> <python-checkins at python.org> wrote:
>> http://hg.python.org/cpython/rev/79ccf36b0fd0
>> changeset:   89239:79ccf36b0fd0
>> user:        Victor Stinner <victor.stinner at gmail.com>
>> date:        Tue Feb 18 01:35:40 2014 +0100
>> summary:
>>   Close #20656: Fix select.select() on OpenBSD 64-bit
>>
>> files:
>>   Modules/selectmodule.c |  22 ++++++++++++----------
>>   1 files changed, 12 insertions(+), 10 deletions(-)
>
> This changeset caused a compile warning on 32-bit Windows:
>
> ..\Modules\selectmodule.c(238): warning C4244: '=' : conversion from
> 'time_t' to 'long', possible loss of data
> [P:\ath\to\cpython\PCbuild\select.vcxproj]

Ah yes, I didn't remember why I wrote the downcast initially. You're
right, it is still neeed (on 64-bit Windows). I restored it:
---
user:        Victor Stinner <victor.stinner at gmail.com>
date:        Tue Feb 18 09:30:33 2014 +0100
files:       Modules/selectmodule.c
description:
Issue #20656: Restore explicit downcast in select_select().

Cast from time_t (64 bit) to long (32 bit). It should fix a compiler warning.
---

Victor