[Python-Dev] Start writing inlines rather than macros?
Kristján Valur Jónsson
kristjan at ccpgames.com
Thu Feb 27 11:22:05 CET 2014
The discussion on http://bugs.python.org/issue20440 started me thinking that much of this
bikeshedding could be avoided if we weren't constrained to writing macros for all of this stuff.
For example, a
Py_INLINE(PyObject *) Py_Incref(PyObject *obj)
could be used in a Py_Assign() function, if a new reference were wanted:
Py_INLINE(void) Py_Assign(PyObject ** target, PyObject *obj)
PyObject *tmp = *target;
*target = tmp;
So that you could then safely write code like
This would also allow you to stop writing various super macros to try to cater to all possible permutations.
Now, Larry Hastings pointed out that we support C89 which doesn't support Inlines. Rather than suggesting here that we update that compatibility requirement,
how about adding a Py_INLINE() macro.? This would be like Py_LOCAL_INLINE() except that it would drop the "static" keyword, unless inline isn't supported:
#define Py_INLINE(type) __inline type
#define Py_INLINE(type) inline type
#define Py_INLINE(type) static type
The only question is with the last line. How many platforms actually _do_not_ have inlines? Would writing stuff like this be considered problematic for those platforms? Note, that I'm not suggesting replacing macros all over the place, only for new code.
Another question is: Is "static inline" in any practical way different from "inline"?
It would be great to get rid of macros in code. It would be great for debugging too!
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Python-Dev