[Python-Dev] [Python-checkins] cpython: Issue #19976: Argument Clinic METH_NOARGS functions now always
Stefan Krah
stefan at bytereef.org
Sat Jan 4 21:00:09 CET 2014
Probably Rietveld did not send mail, so I mention my review comments again:
larry.hastings <python-checkins at python.org> wrote:
> +#ifdef __GNUC__
> +#define Py_UNUSED(name) _unused_ ## name __attribute__((unused))
> +#else
> +#define Py_UNUSED(name) _unused_ ## name
> +#endif
> +
The Intel compiler defines __GNUC__ but chokes on the __attribute__().
This works:
#if defined(__GNUC__) && !defined(__INTEL_COMPILER)
> +_pickle_Pickler_clear_memo(PyObject *self, PyObject *Py_UNUSED(ignored))
I'm not a native speaker, but UNUSED(ignored) reads strange to me. I would
prefer UNUSED(args).
Stefan Krah
More information about the Python-Dev
mailing list