[Python-Dev] cpython (3.3): Make the various iterators' "setstate" sliently and consistently clip the

Georg Brandl g.brandl at gmx.net
Sat Mar 8 08:01:23 CET 2014


Am 06.03.2014 09:02, schrieb Serhiy Storchaka:
> 05.03.14 17:24, kristjan.jonsson написав(ла):
>> http://hg.python.org/cpython/rev/3b2c28061184
>> changeset:   89477:3b2c28061184
>> branch:      3.3
>> parent:      89475:24d4e52f4f87
>> user:        Kristján Valur Jónsson <sweskman at gmail.com>
>> date:        Wed Mar 05 13:47:57 2014 +0000
>> summary:
>>    Make the various iterators' "setstate" sliently and consistently clip the
>> index.  This avoids the possibility of setting an iterator to an invalid
>> state.
> 
> Why indexes are silently clipped instead of raising an exception?
> 
>> files:
>>    Lib/test/test_range.py    |  12 ++++++++++
>>    Modules/arraymodule.c     |   2 +
>>    Objects/bytearrayobject.c |  10 ++++++--
>>    Objects/bytesobject.c     |  10 ++++++--
>>    Objects/listobject.c      |   2 +
>>    Objects/rangeobject.c     |  31 +++++++++++++++++++++++---
>>    Objects/tupleobject.c     |   4 +-
>>    Objects/unicodeobject.c   |  10 ++++++--
>>    8 files changed, 66 insertions(+), 15 deletions(-)
> 
> And it would be better first discuss and review such large changes on 
> the bugtracker.

Agreed.  Kristjan, could you please explain a bit more about this change
and use the tracker in the future?

Georg



More information about the Python-Dev mailing list