[Python-Dev] [Python-checkins] cpython: Issue #23152: Implement _Py_fstat() to support files larger than 2 GB on

[Ben Hoyt]

When merging some changes while working on scandir, I noticed a minor issue
with this commit:

https://hg.python.org/cpython/rev/4f6f4aa0d80f

The definition of "struct win32_stat" has been moved to fileutils.h and
renamed to "struct _Py_stat_struct", which is fine -- however, the old
"struct win32_stat" definition is still present (but unused) in
posixmodule.c.

So I think the old "struct win32_stat { ... }" definition can simply be
removed from posixmodule.c now.

Also, unrelated to this commit, I notice the _Py_attribute_data_to_stat
function (was attribute_data_to_stat) can't fail and always returns 0, and
all callers ignore its return value anyway. Can it be changed to return
void?

-Ben
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-dev/attachments/20150221/9d9ed333/attachment.html>