[Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

Maciej Fijalkowski fijall at gmail.com
Tue Jul 7 12:04:34 CEST 2015


I must say I completely fail to understand the procedures under which
python is developed. If the change (unreviewed, just randomly applied)
causes crashes, then surely it should be reverted first and continued
on bug tracker instead of lingering (and the complain sitting on bug
tracker)?

On Tue, Jul 7, 2015 at 10:10 AM, Serhiy Storchaka <storchaka at gmail.com> wrote:
> On 07.07.15 10:42, Serhiy Storchaka wrote:
>>
>> On 07.07.15 05:03, raymond.hettinger wrote:
>>>
>>> https://hg.python.org/cpython/rev/c9782a9ac031
>>> changeset:   96865:c9782a9ac031
>>> user:        Raymond Hettinger <python at rcn.com>
>>> date:        Mon Jul 06 19:03:01 2015 -0700
>>> summary:
>>>    Tighten-up code in the set iterator to use an entry pointer rather
>>> than indexing.
>
>
>> What if so->table was reallocated during the iteration, but so->used is
>> left the same? This change looks unsafe to me.
>
>
> There is crash reproducer.
>
> http://bugs.python.org/issue24581
>
>
> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> https://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe:
> https://mail.python.org/mailman/options/python-dev/fijall%40gmail.com


More information about the Python-Dev mailing list