[Python-Dev] [bpo-30421]: Pull request review
Mark Lawrence
breamoreboy at yahoo.co.uk
Mon Aug 28 16:43:11 EDT 2017
On 28/08/2017 17:46, Terry Reedy wrote:
> On 8/28/2017 3:42 AM, Robert Schindler wrote:
>> Hello,
>>
>> In May, I submitted a pull request that extends the functionality of
>> argparse.ArgumentParser.
>
> The argparse maintainer, bethard (Peter Bethard), was not added to the
> nosy list. And he does not seem to have been active lately -- his bpo
> profile does not list a github name.
>
>> To do so, I followed the steps described in the developers guide.
>>
>> According to [1], I already pinged at GitHub but got no response. The
>> next step seems to be writing to this list.
>>
>> I know that nobody is payed for reviewing submissions, but maybe it just
>> got overlooked?
>>
>> You can find the pull request at [2].
>
>> [1] https://docs.python.org/devguide/pullrequest.html#reviewing
>> [2] https://github.com/python/cpython/pull/1698
>
> Some core developer has to decide if the new feature should be added,
> and if so, what the API should be. If Peter is not doing that, I don't
> know who will. It is possible that the current design is intentional,
> rather than an oversight. It does not make too much sense to review the
> implementation (the PR) until the design decisions are made. In this
> case, the PR adds a feature not discussed on the bpo issue.
>
The bulk of the work on argparse in recent years has been done by
paul.j3. I have no idea whether or not he is classed as a core developer.
--
My fellow Pythonistas, ask not what our language can do for you, ask
what you can do for our language.
Mark Lawrence
---
This email has been checked for viruses by AVG.
http://www.avg.com
More information about the Python-Dev
mailing list