[Python-Dev] Helping contributors with chores (do we have to?)
solipsis at pitrou.net
Sun Jun 25 14:51:04 EDT 2017
On Sun, 25 Jun 2017 20:38:51 +0200
Stefan Krah <stefan at bytereef.org> wrote:
> On Sun, Jun 25, 2017 at 10:02:44AM -0700, Nathaniel Smith wrote:
> > https://help.github.com/articles/committing-changes-to-a-pull-request-branch-created-from-a-fork/
> > However, like Antoine, when I've tried to do this then all I've managed is
> > to get obscure errors from GitHub. Did I have the wrong incantations? Was
> > the permissions toggle set wrong? (I thought the web ui said it wasn't, but
> > maybe I misunderstood.) It's a mystery. Has anyone figured out how to make
> > *this* work reliably or ergonomically?
> I don't know either. Adding .patch to the PR URL, downloading the thing,
> editing as necessary and crediting the author in the commit message would
> be much much faster.
I might do that as well (actually did on another project after I
borked an attempt to push to the submitter's branch). Of course it
doesn't work if your aim is to collaborate with the submitter, only if
you want to take over and apply some polish before pushing.
More information about the Python-Dev