[Python-Dev] Rename Include/internals/ to Include/pycore/

Victor Stinner vstinner at redhat.com
Wed Oct 31 19:36:09 EDT 2018


Ok, thanks. I decided to remove the redundant "py", so I renamed
"pystate.h" to "pycore_state.h" (single "py", instead of
"pycore_pystate.h", double "py py").

I updated my PR:
https://github.com/python/cpython/pull/10263

* Rename Include/internal/ header files:

  * pyatomic.h -> pycore_atomic.h
  * ceval.h -> pycore_ceval.h
  * condvar.h -> pycore_condvar.h
  * context.h -> pycore_context.h
  * pygetopt.h -> pycore_getopt.h
  * gil.h -> pycore_gil.h
  * hamt.h -> pycore_hamt.h
  * hash.h -> pycore_hash.h
  * mem.h -> pycore_mem.h
  * pystate.h -> pycore_state.h
  * warnings.h -> pycore_warnings.h

* PCbuild project, Makefile.pre.in, Modules/Setup: add the
  Include/internal/ directory to the search paths of header files.
* Update include. For example, replace #include "internal/mem.h"
  with #include "pycore_mem.h".

Victor
Le mer. 31 oct. 2018 à 23:38, Eric Snow <ericsnowcurrently at gmail.com> a écrit :
>
> B
> On Wed, Oct 31, 2018 at 4:28 PM Victor Stinner <vstinner at redhat.com> wrote:
> >
> > Le mer. 31 oct. 2018 à 22:19, Eric Snow <ericsnowcurrently at gmail.com> a écrit :
> > > > Maybe we can keep "Include/internal/" directory name, but add
> > > > "pycore_" rather than "internal_" to header filenames?
> > >
> > > this sounds good to me.  thanks for chasing this down.
> >
> > What do you prefer?
> >
> > (A Include/internal/internal_pystate.h
> > (B) Include/internal/pycore_pystate.h
> > (C) Include/pycore/pycore_pystate.h
> >
> > Victor


More information about the Python-Dev mailing list