[Python-Dev] Adding shlex.join?
Eric S. Raymond
esr at thyrsus.com
Wed Apr 17 12:29:25 EDT 2019
Paul Ganssle <paul at ganssle.io>:
> Hey all,
> I've been reviewing old "awaiting review" PRs recently, and about a week
> ago I found PR #7605 <https://github.com/python/cpython/pull/7605>,
> adding shlex.join(), with a corresponding bug at bpo-22454
> <https://bugs.python.org/issue22454>. The PR's implementation is simple
> and seems reasonable and decently well-tested, but it has been
> unreviewed for ~10 months.
> The reason I'm bringing it up here is that I believe the major blocker
> here is getting agreement to actually add the function. There doesn't
> seem to be much /opposition/ in the BPO issue, but given how
> infrequently the shlex module is changed I'm worried that there may be
> no one around who feels confident to judge how the interface should evolve.
> Does anyone feel strongly about this issue? Is there anyone who wants to
> make a yes/no decision on this feature?
> P.S. The PR's submitter seems responsive. I made a comment on the
> documentation and it was addressed in something like 5 minutes.
I'm the person who originally wrote shlex, which I guess makes me the
authority on designer's intention.
Providing this addition is properly unit-tested (which apparently it is)
I don't have any objection to it. Seems like a reasonable idea.
So I'll say yes. But I haven't touched this code in a long time. Maybe
somebody on the core dev team thinks they own it now; if so, they might
well be right. If so, that person should speak up.
I suspect, however, that this code has nobody actively maintaining it
because it Just Works. In which case, the authority to make this change
should rest with the person who took the responsibility to review it.
That would be *you.*
So my advice is: pull the trigger. Get forgiveness if it turns out you need
it. I don't expect you will.
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: not available
More information about the Python-Dev