[Python-ideas] Tulip patches

[Felipe Cruz]

Hi Guido!

I was just hacking without thinking about actually make patches. I can make
patches without 3rd parties dependencies and no Makefile modification. :)

I'll fix the second issue.




2012/12/21 Guido van Rossum <guido at python.org>

> On Fri, Dec 21, 2012 at 10:09 AM, Felipe Cruz <felipecruz at loogica.net>
> wrote:
> > I've been working in some tests to the pollers (Kqueue, Epoll ..) that
> may
> > interest you guys.. My goal is to create test cases for each poller
> > situation (ie: how to detect client disconnection with epoll and unix
> pipes?
> > or tcp sockets..) and understand how all those pollers are different from
> > each other and how we can map a generic events with all those possible
> > underlying implementations.
>
> That goal sounds great.
>
> > I already  did some Epoll and Kqueue tests here:
> > https://bitbucket.org/felipecruz/tulip/commits
>
> Hm... Your clone is behind, a lot has changed since you made those
> commits. You may have to merge from the main repo.
>
> Specific comments:
>
> - I prefer to use my existing test infrastructure rather than 3rd
> party tools; dependencies in this early stage make it too hard for
> people to experiment. (It's okay to add a rule to the Makefile to
> invoke your favorite test discovery tool; but it's not okay to add
> imports to the Python code that depends on a 3rd party test
> framework.)
>
> - Your code to add flags or eventmask to the events list seems
> incomplete -- the UnixEventLoop doesn't expect poll() to return a
> tuple so all my own tests break...
>
> --
> --Guido van Rossum (python.org/~guido)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-ideas/attachments/20121221/0e6e8dc0/attachment.html>