[Python-ideas] Make "is" checks on non-singleton literals errors

Barry Warsaw barry at python.org
Mon Oct 8 22:26:49 CEST 2012


On Oct 08, 2012, at 03:44 PM, Mike Graham wrote:

>I regularly see learners using "is" to check for string equality and
>sometimes other equality. Due to optimizations, they often come away
>thinking it worked for them.
>
>There are no cases where
>
>    if x is "foo":
>
>or
>
>   if x is 4:
>
>is actually the code someone intended to write.
>
>Although this has no benefit to anyone but new learners, it also
>doesn't really do any harm.

Conversely, I often see this:

    if x == None

and even

    if x == True

Okay, so maybe these are less harmful than the original complaint, but still,
yuck!

-Barry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/python-ideas/attachments/20121008/b09c907f/attachment.pgp>


More information about the Python-ideas mailing list