[Python-ideas] site.py uses os.sep to determine platform

[Stephan Houben]

Well to be pedantic, the code is obviously wrong since it assumes EOF is
generated by ctrl-D, but the user could have changed that with stty. It
should query the terminal settings instead...

Yeah I know, people who do that don't need the message.

Op 12 feb. 2017 4:26 p.m. schreef "Steve Dower" <steve.dower at python.org>:

> It depends on what the code beneath the if is doing. "Windows" may be a
> shorthand for "uses backslash", in which case the check is correct.
>
> We should certainly match the check to the intent, but we need to
> determine the intent first.
>
> Cheers,
> Steve
>
> Top-posted from my Windows Phone
> ------------------------------
> From: Alex Walters <tritium-list at sdamon.com>
> Sent: ‎2/‎12/‎2017 4:35
> To: python-ideas at python.org
> Subject: [Python-ideas] site.py uses os.sep to determine platform
>
> On august 7th, 1998, Guido committed
> https://github.com/python/cpython/commit/d89fa0c5761254c970af72e5abcea4
> 20fd2
> 3e893 to python, adding the quit() and exit() built-ins.  He decided to
> determine the platform python was running on by checking os.sep.  I don't
> understand the rationale behind this choice in 1998, but I assume that
> there
> was one.
>
> It's 2017.  We have sys.platform, and the standard library is tested
> against
> everything that vanilla cpython (unpatched by a vendor) will ever put in
> cpython.
>
> Is there any reason not to change os.sep == '\\' to sys.platform == 'win32'
> in 2017?
>
> _______________________________________________
> Python-ideas mailing list
> Python-ideas at python.org
> https://mail.python.org/mailman/listinfo/python-ideas
> Code of Conduct: http://python.org/psf/codeofconduct/
>
> _______________________________________________
> Python-ideas mailing list
> Python-ideas at python.org
> https://mail.python.org/mailman/listinfo/python-ideas
> Code of Conduct: http://python.org/psf/codeofconduct/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-ideas/attachments/20170212/6c4ca918/attachment.html>