[python-ldap] Server-side Sorting control lib

Michael Ströder michael at stroeder.com
Thu Apr 7 16:20:15 EDT 2016


Simon Pichugin wrote:
> My name is Simon. I am from Red Hat, Red Hat Directory Server team.
> I've started to work closely with python-ldap and I want to contribute
> to it.
> 
> For a start, I want to make Server-side Sorting control lib better
> (Lib/ldap/controls/sss.py). I've copied it and have tested with 
> 389 Directory Server and it works.

Contributions are highly appreciated.

> Only one thing. For now it should be run like this (regarding 389ds):
>>>> s = SSSRequestControl(['-cn'])
> 
> Not like it's mentioned in the doc string on line 51:
>>>> s = SSSRequestControl('-cn')
> 
> Because then we have a problem on the line 70, where we will iterate
> through our rule string and divide it into chars.
> 
> Also, I see "rule.split(':')" there on line 76. So we can either go this way
> with one string like 'cn:sn' or just put list of attributes there like
> ['cn', 'sn'] and add variable for reverse ordering posibility.

Noted. It seems my review was not thorough enough when I accepted this contribution.

> And one more thing. I also want to add tests for this feature.

Tests are welcome.

> So here comes the question. What does my course of action should look like
> if I want to help the project?

Just send in a patch against CVS HEAD (as attachment).
Or whole files are ok too.

> P.S. as I see, sss.py is not in the setup.py now.

Fixed in CVS HEAD.

Ciao, Michael.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://mail.python.org/pipermail/python-ldap/attachments/20160407/1d118be2/attachment.bin>


More information about the python-ldap mailing list