[python-ldap] Tests run by hand

[Petr Viktorin]

On 02/01/2017 07:43 PM, Michael Ströder wrote:
> Petr Viktorin wrote:
>> On 01/09/2017 05:32 PM, Michael Ströder wrote:
>>> Petr Viktorin wrote:
>>>> These tests:
>>>>
>>>> Tests/Lib/ldap/schema/test_tokenizer.py
>>>> Tests/Lib/ldap/test_modlist.py
>>>> Tests/Lib/test_ldapurl.py
>>>>
>>>> only signal failure by printing to stdout. This makes them cumbersome to run
>>>> automatically.
>>>> Is there a reason for this behavior?
>>>
>>> Ancient historic artefacts before automated testing got normal. ;-)
>>>
>>>> Would you accept a patch that converts them to unittest and adds them to
>>>> runtests.sh?
>>
>> It's low priority, other projects are taking up a lot of my time, but I'm slowly
>> working on this.
>
> Take your time.

Here is a patch.
If you have some other idea on organization (like moving the files to 
t_*.py with the other unittest-based ones) , let me know.


>> I noticed that the last two test cases in Tests/Lib/ldap/schema/test_tokenizer.py
>> (marked "for Oracle") fail.
>> Unfortunately LDAP tokenization is beyond my experience, I can't tell what the behavior
>> should be here. Can you shed some light on it?
>
> Well, I tried to work around some interop issues with non-LDAPv3-compliant schema
> definitions in Oracle Internet Directory (OID) and therefore added these test-cases.
>
> This was ages ago and not successful anyway. I also don't have access to OID myself and
> therefore I can't tell whether that's still relevant today. So I'd recommend to simply
> ignore (comment) this test-cases.

Thanks; commented.


-- 
Petr Viktorin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: use-unittest.patch
Type: text/x-patch
Size: 22262 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/python-ldap/attachments/20170214/f680373b/attachment-0001.bin>