[python-ldap] syncrepl fix for pyasn1 >= 0.3

[Ilya Etingof]

Hi Michael,

Here is my first take on the `default` feature:

    https://github.com/etingof/pyasn1/pull/100 <https://github.com/etingof/pyasn1/pull/100>

I appreciate your suggestions and feedback!

Thanks!

> On 11 Nov 2017, at 23:34, Michael Ströder <michael at stroeder.com> wrote:
> 
> Ilya Etingof wrote:
>> I’d only suggest slight re-wording for this piece of code:
>> 
>>          self.result = int(p.getComponentByName('virtualListViewResult'))
>>          self.result_code = p.getComponentByName(‘virtualListViewResult’).prettyOut(self.result)
>> 
>> Into something like this mostly for clarity:
>> 
>>          self.result = int(p.getComponentByName('virtualListViewResult'))
>>          self.result_code = p.getComponentByName(‘virtualListViewResult’).prettyPrint()
> 
> When reviewing sss.py and vlv.py I wondered why I've accepted those
> modules like this back then.
> 
> Especially I wonder whether attribute .result_code should be set at all
> because the calling application could easily invoke .prettyPrint()
> itself if needed.
> 
> I'm inclined to drop those lines for sake of performance.
> 
>> ps. I’m working on adding defaults to the pyasn1 getters.
> 
> Great!
> 
> Ciao, Michael.
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-ldap/attachments/20171112/c79523da/attachment.html>