[python-ldap] [PATCH] Tests: Don't overwrite the server attribute of parent class

Miro Hrončok mhroncok at redhat.com
Thu Nov 16 10:37:12 EST 2017


Hi,

We'd find out that the code in 
Tests/t_ldapobject.py::Test01_SimpleLDAPObject overwrites the server 
attribute of parent class by calling SlapdTestCase.setUpClass() 
directly. This might in some cases be problematic, as described in [0], 
a fix is to use super().

Attaching a patch for python-ldap. Source: [1]

[0] https://github.com/pyldap/pyldap/pull/122
[1] https://github.com/pyldap/pyldap/pull/122#issuecomment-327441677
-- 
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Tests-Don-t-overwrite-the-server-attribute-of-parent.patch
Type: text/x-patch
Size: 854 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/python-ldap/attachments/20171116/efbd45d9/attachment.bin>


More information about the python-ldap mailing list