Defending the Python lanuage...

[Justin Sheehy]

"Peter Milliken" <peter.milliken at gtech.com> writes:

> Actually, if you are *good* at what you do, then code review, whilst still
> beneficial, is not nearly *that* beneficial.

I deeply disagree.

Some of the most valuable code reviews that I've seen at my current
employer have been of programs written by very competent programmers.

First off, no one is perfect.  A few more pairs of eyes on the code
that are explicitly looking for odd things can be very useful in
finding subtle problems.

Also, it is very possible that a requirement or interrelationship has
been ignored or mishandled.  Even if the code is good in a relative
vacuum, having someone with a different day-to-day focus look at it
can help to expose important issues.

There is another major benefit of code review that may not occur to
you, since it is not a direct benefit to the code being reviewed.
Code reviews are an excellent way for programmers of all skill levels
to learn from each other.  This is one of the major reasons that I
like them, even if they take a bunch of time out of my schedule.

-Justin