Correct code/unit testing (was Re: Efficient python programming...)

[Peter Hansen]

"Delaney, Timothy" wrote:
> 
> > From: Peter Hansen [mailto:peter at engcorp.com]
> > I have to confess I have never seen a successful code review, nor
> > an environment in which they were used regularly and which had a
> > high level of code quality.  Clearly as a result I'm fairly biased
> > against them -- I should keep a more open mind on the issue perhaps.
> 
> I presume you mean a full, formal review by a group for a large piece of
> code?

In that paragraph, yes, I meant that.

> I'm certain that with your experience with XP, you have seen and taken part
> in *many* successful reviews (where success means the code is improved as a
> result).

I think I tried to say that later in the message.  If pair programming
is considered the same as "review", then I agree.  Of course, pair 
programming is _much_ more than review-as-you-code, but that's another
topic.

-Peter