Minidom empty script element bug

Derek Basch dbasch at yahoo.com
Wed Mar 16 03:45:03 CET 2005


Martin v. Löwis wrote:
> Derek Basch wrote:
> > XHTML 1.0 specs, Appendix C
> > ~~~~@~~~~
> > C.3 Element Minimization and Empty Element Content
> >
> > Given an empty instance of an element whose content model is not
EMPTY (for
> > example, an empty title or paragraph) do not use the minimized form
(e.g.
> > use <p> </p> and not <p />)
> > ~~~~@~~~~
>
> I'd like to point out that this is *not* a minidom bug. minidom
cannot
> possibly know that the document type is XHTML, and that strange,
non-XML
> rules apply to XHTML (i.e. rules which are not present in XML
itself).
>
> I'd also like to point out that XHTML Appendix C is informative (i.e.
> non-normative), meaning that failure to comply to it does not imply
> non-compliance with XHTML. An XML file which uses the minimized form
> for the script element is still proper, well-formed, valid XHTML.
>
> > How do I get minidom to NOT render an empty script element? Should
I submit a
> > bug report?
>
> That said, I think there is a simple solution: add an empty Text node
> to the script element:
>
> script_node_0.appendChild(doc.createText(u""))
>
> [Disclaimer: this is untested; from reading the source, I think it
> should work]
>
> Regards,
> Martin


Thanks Martin. That fixed it. I had to change your code a bit to this:

script_node_0.appendChild(self.doc.createTextNode(""))

maybe you meant createTextNode?

I started digging through the dom modules on this path:

XHTMLPrettyPrint -> XHTMLPrinter -> Printer

and found this comment:

try:
    #The following stanza courtesy Martin von Loewis
    import codecs # Python 1.6+ only
    from types import UnicodeType

So I guess you are pretty qualified to answer my question! You are
correct that this is not a minidom bug now that I think about it.

However, it seems proper that XHTMLPrinter (or some other module)
should allow the developer to use either normative or non-normative
XHTML design guidlines to achieve some sane degree of HTML user agent
compatablilty. Maybe something like this in Printer.py:

def visitElement(self, node):
    ...........
        if len(node.childNodes):
            self._write('>')
            self._depth = self._depth + 1
            self.visitNodeList(node.childNodes)
            self._depth = self._depth - 1
            if not self._html or (node.tagName not in
HTML_FORBIDDEN_END):
                not (self._inText and inline) and self._tryIndent()
                self._write('</%s>' % node.tagName)
        elif not self._html and node.tagName not in
XHTML_NON_NORMATIVES:
            self._write('/>')
        elif node.tagName not in HTML_FORBIDDEN_END:
            self._write('></%s>' % node.tagName)
        else:
            self._write('>')

of course this would only take care of the "C.3. Element Minimization
and Empty Element Content" guideline but you get the general idea.

Anyways, thanks for the help again and feel free to shoot down my
suggestions :)

Derek Basch




More information about the Python-list mailing list