Code Review request for the trash-cli project

[Dotan Cohen]

2009/1/6 Andrea Francia
<andrea.francia at remove-from-here.ohoihihoihoih.to-here.gmx.it>:
> The trash-cli project is a opensource implementation of the FreeDesktop.org
> Trash Specification that provides a command line interface to manage the
> trashcan.
>
> It's provide the following commands:
>  * trash-put          trashes files and directories.
>  * trash-empty         empty the trashcan(s).
>  * trash-list          list trashed file.
>  * trash-restore       restore a trashed file.
>
> It is written in python and its sources are available at
>
>  http://code.google.com/p/trash-cli/source/browse/#svn/trunk
>
> I'm the main developer and I'm not so good in Python as I would be.
>
> Would you review my software and point out the problems you see?
>
> The review comments can be written using the code-review facilities of
> google code. You need only to double click the line of code where you want
> add a comment.
>
> Patches are also welcome.
>
> Thank you.
>

I don't know about the code, but would there be a reason _not_ to
alias rm, rmdir to this program? I see that it is GPL, so this would
be a great addition to any Linux distro.

-- 
Dotan Cohen

http://what-is-what.com
http://gibberish.co.il

א-ב-ג-ד-ה-ו-ז-ח-ט-י-ך-כ-ל-ם-מ-ן-נ-ס-ע-ף-פ-ץ-צ-ק-ר-ש-ת
ا-ب-ت-ث-ج-ح-خ-د-ذ-ر-ز-س-ش-ص-ض-ط-ظ-ع-غ-ف-ق-ك-ل-م-ن-ه‍-و-ي
А-Б-В-Г-Д-Е-Ё-Ж-З-И-Й-К-Л-М-Н-О-П-Р-С-Т-У-Ф-Х-Ц-Ч-Ш-Щ-Ъ-Ы-Ь-Э-Ю-Я
а-б-в-г-д-е-ё-ж-з-и-й-к-л-м-н-о-п-р-с-т-у-ф-х-ц-ч-ш-щ-ъ-ы-ь-э-ю-я
ä-ö-ü-ß-Ä-Ö-Ü