PyWart: Language missing maximum constant of numeric types!

Jean-Michel Pichavant jeanmichel at sequans.com
Mon Feb 27 12:55:52 CET 2012


Rick Johnson wrote:
> On Feb 25, 11:54 am, MRAB <pyt... at mrabarnett.plus.com> wrote:
>   
>> [...]
>> That should be:
>> if maxlength is not None and len(string) <= maxlength:
>>     
>
> Using "imaginary" infinity values defiles the intuitive nature of your
> code. What is more intuitive?
>
> def confine_length(string, maxlength=INFINITY):
>     if string.length < maxlength:
>         do_something()
>
> def confine_length(string, maxlength=None):
>     if maxlength is not None and len(string) <= maxlength:
>         do_something()
>   
This one:

def confine_length(string, maxlength=None):
    """Confine the length.

    @param maxlength: the maximum length allowed, set it to None to allow any length.
    """
    if maxlength is not None and len(string) <= maxlength:
        do_something()


I'm just feeding the troll, I know ... :-/

JM



More information about the Python-list mailing list