Linux shell to python

Jürgen A. Erhard jae+python at jaerhard.com
Mon Jul 30 13:31:30 CEST 2012


On Mon, Jul 30, 2012 at 12:35:38PM +0200, Philipp Hagemeister wrote:
> On 07/30/2012 09:05 AM, Vikas Kumar Choudhary wrote:
> > `lspci | grep Q | grep  "$isp_str1" | grep "$isp_str2" | cut -c1-7'
> 
> The rough Python equivalent would be
> 
> import subprocess
> [ l.partition(' ')[0]      # or l[:7], if you want to copy it verbatim
>   for l in subprocess.check_output(['lspci']).splitlines()
>   if 'Q' in l and isp_str1 in l and isp_str2 in l
> ]

Ouch.  A list comprehension spanning more than one line is bad code
pretty much every time.

But you did qualify it as "rough" :D

Grits, J



More information about the Python-list mailing list