Is there a more elegant way to handle determing fail status?

Ian Kelly ian.g.kelly at gmail.com
Wed Jan 16 01:01:07 CET 2013


On Tue, Jan 15, 2013 at 4:24 PM, J <dreadpiratejeff at gmail.com> wrote:
> The exit code determination above works, but it just feels inelegant.
> It feels like there's a better way of implementing that, but I can't
> come up with one that still honors the fail level properly (e.g. other
> solutions will fail on medium, but won't fail properly on medium OR
> higher).

First, instead of having separate variables 'critical_fails',
'high_fails', etc., put them in a collections.Counter 'fails' keyed by
fail level.
Second, make sure those fail level keys are orderable by severity.

Then your check is just:

if fail_priority <= max(fails):
    return 1
return 0



More information about the Python-list mailing list