Let exception fire or return None
Cecil at decebal.nl
Thu Apr 30 14:22:08 CEST 2015
Op Thursday 30 Apr 2015 13:26 CEST schreef Cecil Westerhof:
>> [line] = itertools.islice(f, index, index+1)
>> except ValueError:
>> raise IndexError
>> return line.rstrip()
> In my case it is not important. (The biggest file I use has between
> 100 and 200 lines), but I publish it, so I should do my best to make
> it so lean as possible.
Implemented and pushed to:
Did some other optimisation's also. The function get_random_message
now calls get_indexed_message. Saves memory (on the old
implementation) and is more DRY.
I also enhanced get_nr_of_messages:
i = -1
with open(expanduser(message_filename), 'r') as f:
for i, l in enumerate(f):
return i + 1
Or can that be done better?
Senior Software Engineer
More information about the Python-list