An improper change in httplib.py

Mark Lawrence breamoreboy at yahoo.co.uk
Thu Jan 22 10:06:31 CET 2015


On 22/01/2015 03:38, Guohua Ouyang wrote:
> This is my first post to the list, I apologies firstly if I made any mistake.
>
> I was trying to get a package in golang behind the http or https
> proxy, and it reports  an error "AttributeError: httpsconnection
> instance has no attribute '_set_hostport'", details in the bottom.
> After some trace work, I found it caused by the changes in the issue issue7776.
>
> @@ -718,7 +734,7 @@
>           else:
>               self._tunnel_headers.clear()
>
> -    def _set_hostport(self, host, port):
> +    def _get_hostport(self, host, port):
>
> First, it changes the method's name, doesn't it break the
> compatibility for other packages, on my system,
> mercurial-3.0-2.fc21.x86_64 still use "_set_hostport" as the error
> shows.
>
> Second, I found that line 1132 of [2] still use "
> self._conn._set_hostport(host, port)", which should be
> "_get_hostport", right?
>
> [1] http://bugs.python.org/issue7776
> [2] https://github.com/python/cpython/blob/2.7/Lib/httplib.py

You've found a bug so please raise it on bugs.python.org :)

-- 
My fellow Pythonistas, ask not what our language can do for you, ask
what you can do for our language.

Mark Lawrence




More information about the Python-list mailing list