Should non-security 2.7 bugs be fixed?

Chris Angelico rosuav at gmail.com
Mon Jul 20 04:59:32 CEST 2015


On Mon, Jul 20, 2015 at 12:16 PM, Rustom Mody <rustompmody at gmail.com> wrote:
> I just ran the following command
> $ hg log --template "{author|person}\n" | sort | uniq -c | sort -nr
>
> as giving all the committers to python in sorted order.
> I get the list below.
> Dont see any Mark Lawrence there
> Of course I dont know hg at all well... Just picked up the above command from
> http://stackoverflow.com/questions/6126678/how-to-list-commiters-sorted-by-number-of-commits-commit-count
>
> So... May I humbly ask where are your precious commits??

Same place that mine aren't. Compare:

http://bugs.python.org/issue24610
https://hg.python.org/cpython/rev/02b81a82a57d

(It's a trivial docs patch, but that makes for a better demo than the
messy PEP 479/issue22906 stuff, where different parts got committed at
different times.)

I create a patch on my local clone of the CPython repository, and
rather than push it directly (which technically I _could_ do, but
socially I don't have jurisdiction over the main source code), I
create a tracker issue and attach the patch. Then someone else commits
it - and it's his name that's on the commit. Same here:

http://bugs.python.org/issue24435
https://hg.python.org/cpython/rev/a9c34db88d79

No matter how many patches I write (not that I write very many), I
won't show up on your list unless I actually push my own code. Mark
isn't a core committer, so you won't see him. A quick search of the
tracker came up with this:

http://bugs.python.org/issue19980

It's a closed issue with a patch by Mark Lawrence. (There may well be
others, I have no idea. All I know is that this one came up in the
search.) The author of the resulting commit is Serhiy, not Mark, so
that's who you'll be counting in your stats.

Sorry to say, the flaw is in your testing methodology.

ChrisA


More information about the Python-list mailing list