[python-win32] win32api - small patch for win32verstamp.py

Chris Clark Chris.Clark at actian.com
Thu Dec 4 01:08:10 CET 2014


I found an hgweb repo for win32api at http://pywin32.hg.sourceforge.net/hgweb/pywin32/pywin32 but I could not work out how to clone it (I even tried the usual Mercurial path for sf projects, http://hg.code.sf.net/p/pywin32/mercurial ) so please excuse the inline diff. rupole, your name was on the last commit hence emailing you!

I've updated win32/Lib/win32verstamp.py to allow empty values for original filename. The previous test was a negative test, if original value is not specified this is set to None, if a user explicitly sets an empty string this will now be used instead of being overwritten and ignored.


C:\ >diff -u C:\Python27\Lib\site-packages\win32\lib\win32verstamp.py win32verstamp.py
--- C:\Python27\Lib\site-packages\win32\lib\win32verstamp.py    Sat Mar 19 02:51
:22 2011
+++ win32verstamp.py    Wed Dec 03 16:03:16 2014
@@ -1,3 +1,5 @@
+# based on Python27\Lib\site-packages\win32\lib\win32verstamp.py
+# original filename now supports empty strings
""" Stamp a Win32 binary with version information.
"""

@@ -126,7 +128,7 @@
   if not ifn:
     ifn = os.path.basename(pathname)
   ofn = options.original_filename
-  if not ofn:
+  if ofn is None:
     ofn = os.path.basename(pathname)

   sdata = {

I have previously signed a PSF contributor agreement https://www.python.org/psf/contrib/ a while back if that helps any.

Regards,

Chris



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-win32/attachments/20141204/08d47889/attachment.html>


More information about the python-win32 mailing list