[python-win32] adodbapi changing autocommit

[Max Slimmer]

Vernon,
Yes, that is what I'm saying, I just didn't want to come out shouting
"bug". I tried setting up the package test at one point but got stuck
somewhere so I'm not sure I'm the person to file the PR (or whatever the
process is). But, I'd be happy to file it using whatever the appropriate
procedure is (if where we're at isn't enough :)).

On Mon, Oct 24, 2016 at 2:57 PM, Vernon D. Cole <vernondcole at gmail.com>
wrote:

> Wait a bit...  Did I just hear that there is a difference in operation
> between starting a connection with autocommit=false and turning autocommit
> off during a session?  If so, I think that's a bug.  PEP-249 has no hook
> for explicitly starting a transaction, so adodbapi needs to always have
> done BeginTrans before any meaningful operation.  Am I missing something?
> --
> Vernon Cole
>
>
> On Mon, Oct 24, 2016 at 11:10 AM, Tim Roberts <timr at probo.com> wrote:
>
>> Max Slimmer wrote:
>> > The adodbapi documentation and code implies that with autocommit =
>> > False I should only have to call commit (and possibly rollback) and if
>> > using the connection as a context manager not even those are required.
>> > If autocommit = False is passed on the initial connect the __init__ of
>> > the connector handles BeginTrans and subsequent commit and rollbacks
>> > also leave me with an open trans.
>>
>> Ah, I missed that subtle distinction.  Your modification seems reasonable.
>>
>> --
>> Tim Roberts, timr at probo.com
>> Providenza & Boekelheide, Inc.
>>
>> _______________________________________________
>> python-win32 mailing list
>> python-win32 at python.org
>> https://mail.python.org/mailman/listinfo/python-win32
>>
>
>


-- 
--Max III
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-win32/attachments/20161025/35885992/attachment.html>