From markv at unity3d.com Thu Feb 20 11:59:18 2020 From: markv at unity3d.com (Mark Visser) Date: Thu, 20 Feb 2020 11:59:18 -0500 Subject: [Python.NET] Working group notes for Feb 13, 2020 Message-ID: Attendees: Victor, Benoit, Amos, Mohammed Agenda Review action items from last meeting: Benoit will write github issue documenting GIL best practices when running multithreaded code and possible solutions [in progress, wiki page + tests] Benedikt will look into splitting up CLR loader into multiple work items to speed up .NET Core support Victor will address comments on codec PR - ready to check in Victor - will work on breaking up Quantconnect PR Mohamed will rebase #974 on top of Victor's codec PR ? - github actions Victor will send Benoit & Felix build that failed on Linux 3.7 Benoit will continue working on PR #1016 Amos is having connection issues and will send an update email to the mailing list Create NuGet organization and transfer package ownership for NuGet package Notes Benoit will work on wiki page + tests for GIL Quantconnect PR Converter-related stuff depends on codecs repository Performance in separate PR Mohamed will rebase #974 - handle generic parameters on action type, needs repo for codecs Victor made repo + NuGet with packaged Python Action Items Benoit to finish wiki page for threading Victor will talk to Benedikt regarding creating a lib/separate repo for codecs Quantconnect PR - Victor to ensure Amos commits are mirrored in master Amos should take over PR #1016 Victor will try to review #958 instead See if Benedikt needs better time or we can make decisions while he?s off Unity is settled on 2.4.0, and might reduce presence The meeting notes google doc is here . Feel free to correct or add additional information. The next meeting will be held on Thursday, February 27th at 12pm EST, 9am PST, 6pm CET, 1am China. Mark Visser Tooling Dev Manager Unity Technologies - www.unity3d.com -------------- next part -------------- An HTML attachment was scrubbed... URL: From support at nuget.org Thu Feb 20 13:56:23 2020 From: support at nuget.org (NuGet Gallery) Date: Thu, 20 Feb 2020 10:56:23 -0800 Subject: [Python.NET] [NuGet Gallery] Membership update for organization 'pythonnet' Message-ID: <4ba345a9f5a849a587c1b4f2bf64d4ea-JVKUGUBNKBZG6ZBNINMTE7COOVDWK5D4IVWWC2LMKB2WE3DJONUGK4T4KNWXI4A=@microsoft.com> The user 'lost' is now an administrator of organization 'pythonnet'. Thanks, The NuGet Gallery Team Privacy Statement (https://go.microsoft.com/fwlink/?LinkId=521839) Microsoft Corporation One Microsoft Way Redmond, WA 98052 USA -------------- next part -------------- An HTML attachment was scrubbed... URL: From markv at unity3d.com Thu Feb 27 13:04:39 2020 From: markv at unity3d.com (Mark Visser) Date: Thu, 27 Feb 2020 13:04:39 -0500 Subject: [Python.NET] Working group notes for Feb 27, 2020 Message-ID: <402945D5-5CD3-48B7-B28E-B59558EFC17F@unity3d.com> Attendees: Victor, Mark, Benedikt, Benoit, Amos, Felix Agenda Review action items from last meeting: Benoit to finish wiki page for threading Victor will talk to Benedikt regarding creating a lib/separate repo for codecs (this also applies to QuantConnect) Quantconnect PR - Victor to ensure Amos commits are mirrored in master Amos should take over PR #1016 Victor will try to review #958 instead See if Benedikt needs better time or we can make decisions while he?s off Unity is settled on 2.4.0, and might reduce presence Create NuGet organization and transfer package ownership for NuGet package At least 1 more person to admin NuGet org Mailing list for maintainers only A plan to replace IntPtr with the new reference types Upstreaming Lost Tech (Victor?s) fork Python 2 support? DllImport -> GetDelegateForFunctionPointer Notes Wiki page for threading is up in tutorials section Victor & Amos discussing failing multithreading test case in PR #1022 Looks like Amos's commits in the Quantconnect PR are already in master PR #1016 closed in favour of using PR #958 instead Slow going on PR #958 review needs some description to explain the changes - a few sentences that describe the intended effects of the changes: what actions are necessary to implement soft shutdown? hard to get overall picture of what the code is expected to do Regarding the time slot this is the best we can get that balances China, North America and Germany time zones it's OK for Victor make decisions in the meeting - unless Benedikt is completely against the decision, it will be OK NuGet org Victor has access problem is that registered e-mail is the mailing list e-mail, security hole A plan to replace IntPtr with the new reference types we should avoid using IntPtr in our own pull requests should use proper pointer types ourselves, once we've got good practices established can be documented belongs with Benedikt's work on loader PR Upstreaming Lost Tech (Victor?s) fork Python 2 support not handled, should we drop support from master (and move 2.x to branch)? DllImport -> GetDelegateForFunctionPointer change require dropping 2.x in general dropping 2.x helps with a lot of things not a problem for Unity, also moving to 3.x No arguments against dropping support for 2.x in master were raised is master in a good state for a last release of 2.x? have one last push to get any changes not specific to 3.x into master before branch-off / tag codecs other minor changes stability of current release? random CI failures we added more tests recently - e.g. domain reload tests unstable one of the domain reload tests often fails on Python 2.7 Amos' changes for normal mode shutdown should solve these failures - should we land them first? no, let's only backport them if there is demand master is currently green As soon as we have all PRs we want in, we will tag 2.4.1 (if no breaking changes, 2.5 otherwise) and branch if necessary will use a github milestone to track PRs for 2.4.1 Still failing tests on 3.8, but likely a dependency on 3.7 - next release should have 3.8 support Lost Tech branch has support for Python version independence (except for 3.8) complete version independence requires dynamic tp slot handling will need runtime logic for handling different versions of Python to handle differing slot locations also need to remove PInvoke usage solving for these two issues will allow any Python version to be used at runtime instead of requiring pre-build for specific versions Lost Tech branch doesn't handle embedding C# in Python, but CLR loader PR should take care of this - already working, and should work with Lost Tech branch changes Dynamic CLR loading won't support 2.4 Action Items Victor will create codecs repo on github Amos to create issue or PR to make implicit operator for reference types to convert reference to IntPtr Amos will create wiki page to explain soft shutdown Benedikt will look into creating a private mailing list for maintainers only Everyone - tag PRs you want to land in 2.4.1, we'll try to get merged before next release Benedikt to check that modernization branch will work with 3.8 The meeting notes google doc is here . Feel free to correct or add additional information. The next meeting will be held on Thursday, March 12th at 12pm EST, 9am PST, 6pm CET, 1am China. Mark Visser Tooling Dev Manager Unity Technologies - www.unity3d.com -------------- next part -------------- An HTML attachment was scrubbed... URL: