Review: Canny
Stéfan van der Walt
stefan at sun.ac.za
Tue Apr 5 06:18:17 EDT 2011
Hi Dan
On Tue, Apr 5, 2011 at 7:51 AM, Dan Farmer <dfarmernv at gmail.com> wrote:
> Thanks for the detailed feedback. I've pushed some more changes that I
> think cover everything. I left the mask and smoothing function for the
> moment based on Thouis feedback.
>
> https://github.com/dfarmer/scikits.image/compare/master...dfarmer-filters-canny
I think we're almost ready to pull!
Some last nitpicks:
- The docstring format requires indentation of items, e.g.
image : array
The image to smooth
- PEP8 suggests not indenting equal signs to be aligned:
not_mask = np.logical_not(mask)
bleed_over = function(mask.astype(float))
...
With these and Chris's changes, I think we're good to go!
Thanks a lot for your effort.
Cheers
Stéfan
More information about the scikit-image
mailing list