[scikit-learn] Code review

[Raghav R V]

Reg. the "Needs Review" tag -

Could I request the maintainers to unlabel the PR once a review has been
completed and is waiting for the author? (Should filter out a lot of
noise). The use case I envision for this tag would be to serve as a
bookmark or a green flag to the maintainer who labels it so he could
revisit later or other maintainers who might have time to look into that
PR. Currently all PRs with `[MRG.*]` are labelled with this (~90) and many
of them are waiting for the author to respond back.

Also I feel it would be useful to have a second label (like Manoj suggested
in a previous thread) to separate those PR which needs to be reviewed in
detail from those which just needs a second look. (read as - a label used
by Maintainer A to signal any other Maintainer who can spare a few minutes
to take a glance and merge). Maybe "Needs Quick Review" / "Needs 2nd
Review"?.

Same for the "Need Contributors" tag. Should be untagged once someone
raises a PR. (A lot of new contributors have complained that those issues
marked "Need Contributors" are taken. I know I am responsible for 2 such
issues :P But I've also asked the commenter to go ahead and raise a PR in
both cases.)

On Thu, Jun 23, 2016 at 2:51 PM, Joel Nothman <joel.nothman at gmail.com>
wrote:

> On 23 June 2016 at 22:47, Raghav R V <ragvrv at gmail.com> wrote:
>
>> > "nag if needed"!
>>
>> I always assume it to be an implicit advice ;P
>>
>
>  I could tell.
>
>
> _______________________________________________
> scikit-learn mailing list
> scikit-learn at python.org
> https://mail.python.org/mailman/listinfo/scikit-learn
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scikit-learn/attachments/20160623/1a5468ec/attachment.html>