[scikit-learn] Github project management tools

[Nelle Varoquaux]

On 28 September 2016 at 10:09, Nelson Liu <nfliu at uw.edu> wrote:
> Maybe something for "stalled" pull requests? e.g. if someone hasn't worked
> on their PR in say 30 days and it's tagged "waiting for changes", you could
> ping them and then put on the "stalled" label. If they don't respond in
> another 15 days / say they aren't working on it anymore, maybe it'd be good
> to change to "abandoned" or "need contributor" (and add "need contributor"
> to the linked issue, if applicable) to indicate that someone else can pick
> it up.
>
> On Wed, Sep 28, 2016 at 10:01 AM, Andreas Mueller <t3kcit at gmail.com> wrote:
>>
>> So following up on this conversation, do we want to use status labels more
>> consistently?
>> And what should they be?
>> Joel Proposed for PRs:
>>
>> * WIP (not ready for review)
>> * waiting for review [we have a tag for this]
>> * waiting for changes (with or without one of the following)
>> * in dispute (i.e. fundamental doubts about the PR)
>> * the above together with 1 or 2 "official" approvals
>> * ready for merge (pending minor changes such as what's new documentation)
>>
>> We could at least add tags for "waiting for changes" and "in dispute",
>> which are fairly clear categories.
>>
>> For PRs we should probably add [bug - not confirmed] and [bug - confirmed]


I think the only ones worth having are the ones that can be dealt with
automatically and the ones that will not be used frequently:

- stalled after 30 days of inactivity [can be done automatically]
- in dispute [I don't expect it to be used often].


WIP, MRG, MRG+N in the title seem IMO a better way to do this. It is
easier than to do with tagging *and* the author of the PR can edit its
own title (which is useful for the two first).

On matplotlib, we have tags for "need review", "need change" and they
are IMO useless. The "need review" is added automatically by a bot as
soon as a PR is opened. It tags PR that are WIP as needed review and
pretty much all of the PRs have it, as no one removes this tag. The
"need change" is used very sparsely because no one ever bothers to put
it (understand as "tagging is annoying" through the UI).

>>
>>
>> On 09/22/2016 01:23 AM, Nelle Varoquaux wrote:
>>>
>>> On 21 September 2016 at 22:13, Andreas Mueller <t3kcit at gmail.com> wrote:
>>>>
>>>>
>>>> On 09/19/2016 09:56 PM, Nelle Varoquaux wrote:
>>>>>>
>>>>>> Another bot-able tool might be pinging inactive PRs to ask if they're
>>>>>> being
>>>>>> worked on, and labelling "Needs contributor" if there's no reply
>>>>>> within n
>>>>>> days...!
>>>>
>>>> That kind of only works when the status is "waiting for changes",
>>>> and not "waiting for reviews". I guess we could tag all old issues
>>>> or use the new interface (though you said that's not scriptable yet?)
>>>> So we would need to actually use the "needs reviews" tag and add an
>>>> "waiting for changes" tag. And I guess the "waiting for changes" should
>>>> be
>>>> removed automatically when the author changed something and changed to
>>>> "needs review"?
>>>>
>>>> Is there an API to access the "fixes #ISSUE" thing for auto-closing?
>>>> Just
>>>> mentioning an issue
>>>> doesn't mean it's a PR to solve the issue.
>>>>
>>>>> If PRs are inactive, it might also be interesting to tag them as
>>>>> easy_fix when there is little to do.
>>>>>
>>>>>
>>>> That's much harder to automate though.
>>>> I know that I often misjudge the amount that is left to do in a PR,
>>>> not sure if bots are better at that than humans yet.
>>>
>>> Bots wouldn't be able to do that, but I find that an hour now and then
>>> scrolling throught old PR works pretty well :)
>>>
>>>> Are there bots with LSTM support yet? ;)
>>>>
>>>> _______________________________________________
>>>> scikit-learn mailing list
>>>> scikit-learn at python.org
>>>> https://mail.python.org/mailman/listinfo/scikit-learn
>>>
>>> _______________________________________________
>>> scikit-learn mailing list
>>> scikit-learn at python.org
>>> https://mail.python.org/mailman/listinfo/scikit-learn
>>
>>
>> _______________________________________________
>> scikit-learn mailing list
>> scikit-learn at python.org
>> https://mail.python.org/mailman/listinfo/scikit-learn
>
>
>
> _______________________________________________
> scikit-learn mailing list
> scikit-learn at python.org
> https://mail.python.org/mailman/listinfo/scikit-learn
>