[scikit-learn] Failing check_estimator on py-earth

[Sebastian Raschka]

Hm, I am actually not sure; could be a bug. When I see it correctly, the problem is in https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/utils/estimator_checks.py#L1519 which could be related to the 'astype' calls in https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/utils/estimator_checks.py#L458 but maybe the scikit-devs know more about this.



> On May 19, 2017, at 6:33 PM, Jason Rudy <jcrudy at gmail.com> wrote:
> 
> Thanks, Sebastian.  I'll consider using that platform check trick to disable the test for 32 bit windows.  It is a small difference, and perhaps not worth all the effort of tracking down.  It's part of check_estimator, so I'd have to disable the entirety of check_estimator I think.  However, testing on 32 bit windows is probably not terribly important.
> 
> On Fri, May 19, 2017 at 3:22 PM, Sebastian Raschka <se.raschka at gmail.com <mailto:se.raschka at gmail.com>> wrote:
> > I'll probably have to set up a 32 bit environment with a debugger and drill down to find the bug,
> 
> Must not be a bug but can simply be due to floating point imprecision. If you checked that this is expected behavior, you could you do sth like
> 
> import numpy.distutils.system_info as sysinfo
> if sysinfo.platform_bits == 32:
>     numpy.testing.assert_array_almost_equal(..., precision=0)
> else:
>     numpy.testing.assert_array_almost_equal(..., precision=2)
> 
> or sth like that?
> 
> Best,
> Sebastian
> 
> > On May 19, 2017, at 6:10 PM, Jason Rudy <jcrudy at gmail.com <mailto:jcrudy at gmail.com>> wrote:
> >
> > I'm pushing to get py-earth ready for a release, but I'm having an issue with the check_estimator function on 32 bit windows machines.  Here is a link to the failing build on appveyor:
> >
> > https://ci.appveyor.com/project/jcrudy/py-earth/build/job/21r6838yh1bgwxw4 <https://ci.appveyor.com/project/jcrudy/py-earth/build/job/21r6838yh1bgwxw4>
> >
> > It appears that array conversion is producing some small differences that make check_estimators_data_not_an_array fail.  I'll probably have to set up a 32 bit environment with a debugger and drill down to find the bug, but I'm wondering if anybody here has tips or experience that might help me guess the problem without doing that.  I am pretty ignorant about numpy type standards and conversions, so even something that seems obvious to you might help me.
> >
> > Best,
> >
> > Jason
> > _______________________________________________
> > scikit-learn mailing list
> > scikit-learn at python.org <mailto:scikit-learn at python.org>
> > https://mail.python.org/mailman/listinfo/scikit-learn <https://mail.python.org/mailman/listinfo/scikit-learn>
> 
> _______________________________________________
> scikit-learn mailing list
> scikit-learn at python.org <mailto:scikit-learn at python.org>
> https://mail.python.org/mailman/listinfo/scikit-learn <https://mail.python.org/mailman/listinfo/scikit-learn>
> 
> _______________________________________________
> scikit-learn mailing list
> scikit-learn at python.org
> https://mail.python.org/mailman/listinfo/scikit-learn