[scikit-learn] Assigning reviewers to PRs

Madhura Jayaratne madhura.cj at gmail.com
Thu Jan 23 00:31:39 EST 2020

Hi Scikit-learn team,

I have submitted a PR implementing support for ICE plots at [1]. There I
noticed that Github suggests reviewers based on the recent edits and
reviews to the files changed in the PR. I am wondering what is the
preferred practice for assigning reviewers. (Initially, I assigned Guillaume
Lemaitre without thinking much, but he cannot review at the moment) I am
wondering, should I assign someone from the suggested list or should I wait
for the core developers to assign themselves?

[1] https://github.com/scikit-learn/scikit-learn/pull/16164

Thanks and Regards,

Madhura Jayaratne
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scikit-learn/attachments/20200123/494eab99/attachment.html>

More information about the scikit-learn mailing list