[SciPy-dev] Statistics Review progress

Tim Leslie tim.leslie at gmail.com
Tue Apr 11 21:25:00 EDT 2006


On 4/11/06, Robert Kern <robert.kern at gmail.com> wrote:

> * anova(): I want to get rid of it. It and its support functions take up
> nearly
> a quarter of the entire code of stats.py. It returns nothing but simply
> prints
> it out to stdout. It uses globals. It depends on several undocumented,
> uncommented functions that nothing else uses; getting rid of anova()
> closes a
> lot of other tickets, too (I subscribe to the "making progress by moving
> goalposts" model of development). It's impossible to unit-test since it
> returns
> no values. Gary Strangman, the original author of most of stats.py,
> removed it
> from his copy some time ago because he didn't have confidence in its
> implementation.
>
> It appears to me that the function would need a complete rewrite to meet
> the
> standards I have set for passing review. I propose to remove it now.



+2. I went through and made some cosmetic changes to stats.py and when I got
to anova() my eyes bugged out. After an hour of head scratching and
scrolling up and down through the code I decided it wasn't worth the effort
to try to decipher quite what was going on. Trying To call the function
showed up bugs in the _support functions. I think the only logical choice at
the stage is to remove anova() and the code which "supports" it.

Cheers,

Timl
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20060412/b417196c/attachment.html>


More information about the SciPy-Dev mailing list