[SciPy-Dev] scipy.stats

[josef.pktd at gmail.com]

On Sat, Apr 21, 2012 at 4:56 PM, nicky van foreest <vanforeest at gmail.com> wrote:
> On 21 April 2012 22:39,  <josef.pktd at gmail.com> wrote:
>> On Sat, Apr 21, 2012 at 4:22 PM, nicky van foreest <vanforeest at gmail.com> wrote:
>>> Hopefully this is the correct link:
>>>
>>> https://github.com/scipy/scipy/blob/master/scipy/stats/distributions.py#L227
>>
>> much easier
>>
>> answer a link https://github.com/scipy/scipy/blob/master/scipy/stats/distributions.py#L453
>>
>> dist is an attribute of the frozen class. the frozen class delegates
>> to the real class and has that attached as `dist`
>>
>> so this is the same as the upper bound .b attribute of the class.
>
> Sure. I have seen this in the code. The point I wanted to make is that
> for a user who doesn't (want to) read the source the text in the
> example is somewhat confusing. Shouldn't these doc strings be targeted
> at plain users (with `plain' I have no derogatory intentions)?

As a user I would think it's just an upper bound for the plot. But I'm
not a good measure for users new to the distributions.

It would be possible to inject a number into the docstring, by
changing the template
https://github.com/scipy/scipy/blob/master/scipy/stats/distributions.py#L1159

Josef

>
>>
>>
>>>
>>> btw, I am compiling a list of points about the scipy.stats code. Once
>>> finished what should I do with it? Would it be best to send it to this
>>> list? Should I send the points one by one, or better as one file?
>>>
>>> I am very enthousiastic about the fact that the code is now easily
>>> accessible via the web.
>>
>> pull request on github?
>>
>> depends on what the "points" are.
>> If you find bugs, individual tickets would be useful. If you find
>> several/many smaller things, then one would make it easier to go over
>> all of them.
>>
>> Josef
>>
>>>
>>>
>>> On 21 April 2012 22:17,  <josef.pktd at gmail.com> wrote:
>>>> On Sat, Apr 21, 2012 at 3:56 PM, nicky van foreest <vanforeest at gmail.com> wrote:
>>>>> Hi,
>>>>>
>>>>> While reading the code and the examples of scipy.stats I came across
>>>>> the attribute rv.dist. Specifically, line 227 of the scipy.stats
>>>>> source on the gibhub server mentions:
>>>>>
>>>>>>>> x = np.linspace(0, np.minimum(rv.dist.b, 3))
>>>>>
>>>>> The problem is that the meaning of this attribute is nowhere
>>>>> explained. Is this a bug?
>>>>
>>>> Do you have the github link to the source? It's not clear which module
>>>> you are talking about.
>>>> (klick on line number and you get the link to that specific line)
>>>> It would safe me some time searching for this.
>>>>
>>>> Josef
>>>>
>>>>
>>>>>
>>>>> Nicky
>>>>> _______________________________________________
>>>>> SciPy-Dev mailing list
>>>>> SciPy-Dev at scipy.org
>>>>> http://mail.scipy.org/mailman/listinfo/scipy-dev
>>>> _______________________________________________
>>>> SciPy-Dev mailing list
>>>> SciPy-Dev at scipy.org
>>>> http://mail.scipy.org/mailman/listinfo/scipy-dev
>>> _______________________________________________
>>> SciPy-Dev mailing list
>>> SciPy-Dev at scipy.org
>>> http://mail.scipy.org/mailman/listinfo/scipy-dev
>> _______________________________________________
>> SciPy-Dev mailing list
>> SciPy-Dev at scipy.org
>> http://mail.scipy.org/mailman/listinfo/scipy-dev
> _______________________________________________
> SciPy-Dev mailing list
> SciPy-Dev at scipy.org
> http://mail.scipy.org/mailman/listinfo/scipy-dev