[SciPy-Dev] ndimage grey morphology tickets

[Jonathan Helmus]

All,

Trac tickets #1135, #1281 and #1498 point out bugs in the 
ndimage.grey_dilation and grey_erosion function.  I've started a branch 
that tries to address these issues: 
https://github.com/jjhelmus/scipy/tree/grey_morphology-fix

This branch currently passes the tests in test_ndimage.py and the 
dilation_test.py file attached to ticket 1135, but I am not certain on 
two issues that I was hoping someone here might be able to comment on them:

1.  Should there be a sanity check on the shape of footprint, structure 
and size when more than one is provided?
2.  Ticket #1281 points out that grey_erosion does not have the 
parameter checking that grey_dilation has.  I added these checks but 
noticed that  to pass tests structure and footprint should not be 
reversed and the origin negated.  Is this correct?  If so the commented 
out lines in the branch should will be deleted.

If this would be better discussed in a pull request I'd be happy to make 
one.

http://projects.scipy.org/scipy/ticket/1135
http://projects.scipy.org/scipy/ticket/1281
http://projects.scipy.org/scipy/ticket/1498


Cheers,

    -Jonathan Helmus