[SciPy-Dev] ENH: Extend peak finding capabilities in scipy.signal (#8264)

[Ralf Gommers]

On Sun, Jan 28, 2018 at 6:05 AM, Lars G. <lagru at mailbox.org> wrote:

> Dear SciPy devs,
>
> >> - argrelmax doesn't catch peaks that are wider than one sample. Decide
> >> how to deal with this. I have implemented an alternative here which may
> >> even be faster. But I plan to make a performance comparison to confirm
> >> this. I have a feeling this should be addressed (if wanted) in a new
> >> pull request.
>
> On 26.01.2018 20:59, Eric Larson wrote:
> > Another PR is fine, but we should merge that one before this find_peaks
> > PR to avoid creating backward compatibility problems.
>
> I have prepared a performance evaluation for you to review here:
> http://nbviewer.jupyter.org/urls/gitlab.com/snippets/1695752/raw


Thanks, such easy to read comparisons are very helpful to evaluate proposed
new functionality.

Regarding the flat peaks issue, I'd have a preference for only a single
index being returned. Rationale:
- whether a peak is considered flat or not can be determined by small
amount of noise (either numerical or real)
- behavior of the function for different inputs should be consistent,
changing the number of returned indices will be annoying for users
Regarding the execution time: that should be only a secondary concern here.

Ralf


> You can download the notebook here:
> https://gitlab.com/snippets/1695752
>
> I hope my approach & evaluation is not to naive. Please let me know

whether you think this approach would be a viable alternative to use in
> find_peaks. In that case I'd start a new PR to add this functionality
> before merging the one we are currently discussing.
>
> Best regards,
> Lars
> _______________________________________________
> SciPy-Dev mailing list
> SciPy-Dev at python.org
> https://mail.python.org/mailman/listinfo/scipy-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20180129/18c49c04/attachment.html>